-
Notifications
You must be signed in to change notification settings - Fork 121
fix: dev-remote hmr port override #4163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
approved these changes
Dec 19, 2025
Collaborator
|
Commit: 5c0e40a
27 interesting tests: 10 KNOWN, 8 RECOVERED, 4 FAIL, 4 flaky, 1 SKIP
Top 27 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: c54498e
28 interesting tests: 14 KNOWN, 7 FAIL, 6 RECOVERED, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This removes the ability to override the hmr port in the vite config to avoid breaking the system.
Why
vite uses the same port for the server and hmr, so by just providing the port override via flag which we already have it works fine.
The problem comes when a user overrides the vite.config.js file with this
This breaks the system, and there's no reason the user will need that when running the dev-remote command as we control it
Tests