Improve folder permissions warning #4216
Open
+216
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the warning message shown when workspace folder has permissions not configured in the bundle. The new message provides clear guidance on how to resolve the issue. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This fixes several issues with the folder permissions validation: 1. Permission hierarchy: Bundle CAN_MANAGE now properly supersedes workspace CAN_VIEW for the same principal (no false warning) 2. Deduplication: When the API returns both inherited and explicit permissions for the same principal, keep only the highest level 3. Current user groups: Suppress warnings for groups the current user belongs to when the user is already tracked in the bundle Also moves PermissionOrder and helpers to resources package for reuse. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove untested current user group tracking code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
lennartkats-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
# Conflicts: # NEXT_CHANGELOG.md
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 60bf54e
27 interesting tests: 13 KNOWN, 11 RECOVERED, 2 flaky, 1 SKIP
Top 38 slowest tests (at least 2 minutes):
|
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This improves the folder permissions warnings, fixing false positives and making any warnings more actionable.
Testing