-
Notifications
You must be signed in to change notification settings - Fork 125
Remove experimental/aitools #4217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removes the experimental/aitools directory and updates all references: - Remove aitools from TEST_PACKAGES in Makefile - Remove test-exp-aitools target and CI job - Remove aitools command from experimental CLI - Remove aitools from CODEOWNERS - Update testmask targets and tests
lennartkats-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, otherwise LGTM
| /cmd/workspace/apps/ @databricks/eng-app-devex | ||
| /libs/apps/ @databricks/eng-app-devex | ||
| /acceptance/apps/ @databricks/eng-app-devex | ||
| /experimental/aitools/ @databricks/eng-app-devex @lennartkats-db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll soon want this back!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes - but it's easier to first cleanly remove it
|
Commit: d9a89a4
27 interesting tests: 23 KNOWN, 2 flaky, 1 RECOVERED, 1 SKIP
Top 26 slowest tests (at least 2 minutes):
|
|
Commit: 4f5748b
44 interesting tests: 24 KNOWN, 7 FAIL, 6 flaky, 5 MISS, 1 PANIC, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Removes the experimental/aitools directory and all references to it throughout the codebase.
Changes:
All tests pass and the code builds successfully.