Rename experimental/apps-mcp to experimental/aitools #4219
Conversation
Renames the directory and updates all references: - Rename experimental/apps-mcp/ to experimental/aitools/ - Update import paths from apps-mcp to aitools - Rename command from 'databricks experimental apps-mcp' to 'databricks experimental aitools' - Update display names from 'Apps MCP'/'Databricks MCP' to 'Databricks aitools' - Rename MCP server name from 'databricks-apps-mcp' to 'databricks-aitools' - Update config/history path from ~/.databricks/apps-mcp to ~/.databricks/aitools - Update test targets from test-exp-apps-mcp to test-exp-aitools - Update CODEOWNERS and CI workflow references
fjakobs
requested review from
a team,
andrewnester,
anton-107,
denik,
lennartkats-db,
pietern and
shreyas-goenka
as code owners
| if: ${{ contains(fromJSON(needs.testmask.outputs.targets), 'test-exp-apps-mcp') }} | ||
| name: "make test-exp-apps-mcp" | ||
| runs-on: ${{ matrix.os }} | ||
|
|
There was a problem hiding this comment.
Don't we still need something like this now you also removed entries in https://github.com/databricks/cli/pull/4217/changes?w=1?
| Hidden: true, | ||
| Short: "Model Context Protocol server for AI agents", | ||
| Short: "Databricks aitools - Model Context Protocol server for AI agents", |
There was a problem hiding this comment.
Should there be any backward compatibility for earlier installations?
There was a problem hiding this comment.
yeah, let me create an alias
| @@ -23,7 +23,7 @@ The MCP server exposes the following capabilities: | |||
|
|
|||
| The server communicates via stdio using the Model Context Protocol.`, | |||
| Example: ` # Start MCP server with required warehouse | |||
| databricks experimental apps-mcp --warehouse-id abc123`, | |||
| databricks experimental aitools --warehouse-id abc123`, | |||
There was a problem hiding this comment.
Btw, probably for later: it would be really good if we had a separate command to start the server. databricks experimental aitools should be a human-facing command group.
There was a problem hiding this comment.
+1 but not piling this on this PR
|
|
||
| .PHONY: lint lintfull tidy lintcheck fmt fmtfull test test-unit test-acc test-slow test-slow-unit test-slow-acc cover showcover build snapshot snapshot-release schema integration integration-short acc-cover acc-showcover docs ws wsfix links checks test-update test-update-templates generate-out-test-toml test-update-aws test-update-all generate-validation | ||
|
|
||
| test-exp-aitools: |
There was a problem hiding this comment.
I thought you were also removing this one in https://github.com/databricks/cli/pull/4217/changes?w=1#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52? Can you double check and make sure we still have appropriate Makefile entries?
|
@lennartkats-db somehow this PR got broken. Created a new one under #4220 Addressed all your feedback there. |
Renames the experimental/apps-mcp directory to experimental/aitools and updates all references throughout the codebase.
Changes:
All tests pass and the code builds successfully.