Fix acceptance tests to use explicit job ID replacements #4225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Captures job ID after deployment and adds to ACC_REPLS for runtime replacement. This prevents non-deterministic test failures when job IDs happen to match timestamp patterns (13-digit numbers starting with 1[78]). Updates 10 acceptance tests: - 9 in bundle/integration_whl/ - 1 in bundle/resources/clusters/run/spark_python_task Each test now: 1. Captures job ID with read_id.py after deployment 2. Adds job_id:JOB_ID mapping to ACC_REPLS 3. Expects [JOB_ID] instead of [NUMID] in Run URLs This follows the pattern established in bundle/resources/jobs/update. Discovered in integration test run 20806115883 where job ID 1719463871887 matched the timestamp regex and was incorrectly replaced with [UNIX_TIME_MILLIS] instead of [NUMID]. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
pietern
requested review from
andrewnester,
anton-107,
denik and
shreyas-goenka
as code owners
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 63ddb5f
27 interesting tests: 20 KNOWN, 4 RECOVERED, 2 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
denik
approved these changes
Jan 9, 2026
Collaborator
|
Commit: af8c7c6
30 interesting tests: 17 KNOWN, 8 RECOVERED, 2 FAIL, 2 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Captures job ID after deployment and adds to
ACC_REPLSfor runtime replacement. This prevents non-deterministic test failures when job IDs happen to match timestamp patterns (13-digit numbers starting with1[78]).Why
Discovered in integration test run where job ID 1719463871887 matched the timestamp regex and was incorrectly replaced with
[UNIX_TIME_MILLIS]instead of[NUMID]:Tests
Updates 10 acceptance tests:
Each test now:
read_id.pyafter deploymentjob_id:JOB_IDmapping toACC_REPLS[JOB_ID]instead of[NUMID]in Run URLsThis follows the pattern established in bundle/resources/jobs/update.