-
Notifications
You must be signed in to change notification settings - Fork 27
Add tokenCache in custom credentialProviders #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add tokenCache in custom credentialProviders #1129
Conversation
| this.token = | ||
| new Token( | ||
| DatabricksJdbcConstants.EMPTY_STRING, | ||
| DatabricksJdbcConstants.EMPTY_STRING, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't token exchange happening for every token if host is different? Though the actual token is cached in their own provider, but still exchanged token is not being reused. Can we cache that as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CachedTokenSource will cache this exchanged token - atleast till the time it expires. Or are you pointing at something else?
src/main/java/com/databricks/jdbc/auth/DatabricksTokenFederationProvider.java
Show resolved
Hide resolved
src/main/java/com/databricks/jdbc/auth/OAuthRefreshCredentialsProvider.java
Show resolved
Hide resolved
src/main/java/com/databricks/jdbc/dbclient/impl/common/ClientConfigurator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/databricks/jdbc/dbclient/impl/common/ClientConfigurator.java
Outdated
Show resolved
Hide resolved
gopalldb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do 1 manual testing for each of affected auth mechanisms?
gopalldb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, make sure that you verify these manually
Description
Testing
Additional Notes to the Reviewer