[telemetry] Add retry logic for partial telemetry push failures#1224
Open
akgitrepos wants to merge 3 commits intodatabricks:mainfrom
Open
[telemetry] Add retry logic for partial telemetry push failures#1224akgitrepos wants to merge 3 commits intodatabricks:mainfrom
akgitrepos wants to merge 3 commits intodatabricks:mainfrom
Conversation
Implements retry logic for partial telemetry push failures. When the telemetry service returns a partial success response, the client now automatically retries up to 3 times with exponential backoff. This addresses the TODO comment in TelemetryPushClient.java. Signed-off-by: Akshey Sigdel <sigdelakshey@gmail.com>
Signed-off-by: Akshey Sigdel <sigdelakshey@gmail.com>
Author
|
@gopalldb @vikrantpuppala Hi, I've implemented retry logic for partial telemetry push failures which was one of the TODO item. Would appreciate a review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements retry logic for partial telemetry push failures in
TelemetryPushClient. When the telemetry service returns a partial success response (numProtoSuccess < totalEvents), the client now automatically retries up to 3 times with exponential backoff (1s → 2s → 4s, max 10s).This addresses the TODO comment in
TelemetryPushClient.java.Changes Made
maxRetriesparameter (default: 3)DatabricksHttpRetryHandler)Testing
pushEvent_noRetryOnFullSuccess- Verifies no retry when all events succeedpushEvent_retriesOnPartialSuccess- Verifies retry is triggered on partial failureAdditional Notes