Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEXT_CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### New Features and Improvements

### Bug Fixes
* Fix issue deserializing HTTP responses with an empty body ([#426](https://github.com/databricks/databricks-sdk-java/pull/426)).

### Documentation

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,8 @@ public <T> void deserialize(Response response, T object) throws IOException {
field.setAccessible(false);
}
}
} else if (response.getBody() != null) {
// mapper does support empty JSON "{}", but not empty body ""
} else if (response.getBody() != null && response.getBody().available() != 0) {
mapper.readerForUpdating(object).readValue(response.getBody());
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,17 @@ void failIdempotentRequestAfterTooManyRetries() throws IOException {
"Request GET /api/2.0/sql/sessions/ failed after 4 retries");
}

@Test
void testEmptyBody() throws IOException {
MyEndpointResponse response = new MyEndpointResponse();
Request request = getBasicRequest();
Response rawResponse = new Response(request, 200, "OK", Collections.emptyMap(), "");
ApiClient client =
getApiClient(request, Collections.singletonList(new SuccessfulResponse(rawResponse)));

client.deserialize(rawResponse, response);
}

@Test
void retryDatabricksApi12RetriableError() throws IOException {
Request req = getBasicRequest();
Expand Down
Loading