-
Notifications
You must be signed in to change notification settings - Fork 33
Add IDTokenSource Interface #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
aa085f5
Add IDTokenSource interface
emmyzhou-db 84e343c
Minor comment change
emmyzhou-db cf96f3a
Add unit tests
emmyzhou-db 04fbc47
Correct formatting
emmyzhou-db bb678fe
Trigger CI
emmyzhou-db 2fa2697
Update databricks-sdk-java/src/main/java/com/databricks/sdk/core/oaut…
emmyzhou-db 45f4fc2
Add test for null
emmyzhou-db File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
31 changes: 31 additions & 0 deletions
31
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/IDToken.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package com.databricks.sdk.core.oauth; | ||
|
|
||
| /** | ||
| * Represents an ID Token provided by an identity provider from an OAuth flow. This token can later | ||
| * be exchanged for an access token. | ||
| */ | ||
| public class IDToken { | ||
| // The string value of the ID Token | ||
| private final String value; | ||
|
|
||
| /** | ||
| * Constructs an IDToken with a value. | ||
| * | ||
| * @param value The ID Token string. | ||
| */ | ||
| public IDToken(String value) { | ||
| if (value == null || value.isEmpty()) { | ||
| throw new IllegalArgumentException("ID Token value cannot be null or empty"); | ||
| } | ||
| this.value = value; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the value of the ID Token. | ||
| * | ||
| * @return The string representation of the ID Token. | ||
| */ | ||
| public String getValue() { | ||
| return value; | ||
| } | ||
| } | ||
12 changes: 12 additions & 0 deletions
12
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/IDTokenSource.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package com.databricks.sdk.core.oauth; | ||
|
|
||
| /** IDTokenSource is anything that returns an IDToken given an audience. */ | ||
| public interface IDTokenSource { | ||
| /** | ||
| * Retrieves an ID Token for the specified audience. | ||
| * | ||
| * @param audience The intended recipient of the ID Token. | ||
| * @return An {@link IDToken} containing the token value. | ||
| */ | ||
| IDToken getIDToken(String audience); | ||
| } |
22 changes: 22 additions & 0 deletions
22
databricks-sdk-java/src/test/java/com/databricks/sdk/core/oauth/IDTokenTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package com.databricks.sdk.core.oauth; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertThrows; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class IDTokenTest { | ||
|
|
||
| private static final String accessToken = "testIdToken"; | ||
|
|
||
| @Test | ||
| void testIDTokenWithValue() { | ||
| IDToken idToken = new IDToken(accessToken); | ||
| assertEquals(accessToken, idToken.getValue()); | ||
| } | ||
emmyzhou-db marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| @Test | ||
| void testIDTokenWithNullValue() { | ||
| assertThrows(IllegalArgumentException.class, () -> new IDToken(null)); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.