Skip to content

[Fix] Fix parsing issue in ErrorDetail (#328) #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blakekingwork wants to merge 1 commit into from
Closed

[Fix] Fix parsing issue in ErrorDetail (#328) #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion databricks-sdk-java/src/main/java/com/databricks/sdk/core/error/ErrorDetail.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public ErrorDetail(
this.type = type;
this.reason = reason;
this.domain = domain;
this.metadata = Collections.unmodifiableMap(metadata);
this.metadata = metadata != null ? Collections.unmodifiableMap(metadata) : null;
}

public String getType() {
Expand Down
11 changes: 11 additions & 0 deletions ...dk-java/src/test/java/com/databricks/sdk/core/error/ApiErrorBodyDeserializationSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,15 @@ void handleUnexpectedFieldsInErrorResponse() throws JsonProcessingException {
assertEquals(error.getErrorCode(), "theerrorcode");
assertEquals(error.getMessage(), "themessage");
}

@Test
void handleNullMetadataFieldInErrorResponse() throws JsonProcessingException {
ObjectMapper mapper = new ObjectMapper();
String rawResponse =
"{\"error_code\":\"METASTORE_DOES_NOT_EXIST\",\"message\":\"No metastore assigned for the current workspace.\",\"details\":[{\"@type\":\"type.googleapis.com/google.rpc.RequestInfo\",\"request_id\":\"1888e822-f1b5-4996-85eb-0d2b5cc402e6\",\"serving_data\":\"\"}]}";
ApiErrorBody error = mapper.readValue(rawResponse, ApiErrorBody.class);

assertEquals(error.getErrorCode(), "METASTORE_DOES_NOT_EXIST");
assertEquals(error.getMessage(), "No metastore assigned for the current workspace.");
}
}
Loading