Skip to content

Add GitHub OIDC authentication support #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parthban-db merged 14 commits into from
May 13, 2025
Merged

Add GitHub OIDC authentication support #444

parthban-db merged 14 commits into from
May 13, 2025

Conversation

@emmyzhou-db
Copy link
Contributor

@emmyzhou-db emmyzhou-db commented May 7, 2025 •
edited
Loading

What changes are proposed in this pull request?

This PR adds support for GitHub OIDC (OpenID Connect) authentication in the Databricks SDK Java.

Key Changes

  • Added GithubIDTokenSource to retrieve JWT tokens from GitHub Actions environment
  • Introduced new TokenSourceCredentialsProvider as a generic provider for token-based authentication flows
  • Updated DefaultCredentialsProvider to support GitHub OIDC and restructured it to facilitate adding other identity providers
  • Added an example demonstrating GitHub OIDC authentication with GitHub Actions

How is this tested?

  • Added unit tests for GithubIDTokenSource and TokenSourceCredentialsProvider
  • Manually validated the authentication flow in a GitHub Actions workflow using the provided example

NO_CHANGELOG=true

@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 7, 2025 16:02 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 7, 2025 16:02 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 8, 2025 10:58 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 8, 2025 10:58 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 8, 2025 11:44 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 8, 2025 11:44 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 9, 2025 13:27 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 9, 2025 13:27 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db changed the title Add GithubIDTokenSource and TokenSourceCredentialsProvider Add GitHub OIDC authentication support May 9, 2025
renaudhartert-db
renaudhartert-db approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@renaudhartert-db renaudhartert-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, deferring approval to @parthban-db

parthban-db
parthban-db reviewed May 10, 2025
View reviewed changes
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 12, 2025 13:41 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 12, 2025 13:41 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 12, 2025 14:26 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 12, 2025 14:26 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db requested a review from parthban-db May 12, 2025 14:55
@emmyzhou-db @renaudhartert-db
Update databricks-sdk-java/src/main/java/com/databricks/sdk/core/Defa…
b527b0c 
…ultCredentialsProvider.java

Co-authored-by: Renaud Hartert <renaud.hartert@databricks.com>
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 12, 2025 16:56 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 12, 2025 16:56 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 12, 2025 16:57 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 12, 2025 16:57 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 12, 2025 17:25 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 12, 2025 17:26 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 13, 2025 08:41 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 13, 2025 08:43 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 13, 2025 09:10 — with GitHub Actions Inactive
@emmyzhou-db emmyzhou-db temporarily deployed to test-trigger-is May 13, 2025 09:10 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented May 13, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-java

Inputs:

  • PR number: 444
  • Commit SHA: e1816201ba9f669d8ae086362c7adcb40cd88b53

Checks will be approved automatically on success.

@parthban-db parthban-db added this pull request to the merge queue May 13, 2025
Merged via the queue into main with commit c092a76 May 13, 2025
15 checks passed
@parthban-db parthban-db deleted the emmyzhou-db/github-oidc branch May 13, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renaudhartert-db renaudhartert-db renaudhartert-db approved these changes

@hectorcast-db hectorcast-db hectorcast-db approved these changes

@parthban-db parthban-db parthban-db approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@emmyzhou-db @hectorcast-db @parthban-db @renaudhartert-db