Add support for OIDC ID token authentication using an environment variables and files #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
reviewed
May 12, 2025
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/FileIDTokenSource.java
Outdated
Show resolved
Hide resolved
parthban-db
reviewed
May 12, 2025
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/FileIDTokenSource.java
Outdated
Show resolved
Hide resolved
parthban-db
reviewed
May 12, 2025
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/FileIDTokenSource.java
Outdated
Show resolved
Hide resolved
parthban-db
reviewed
May 12, 2025
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/EnvVarIDTokenSource.java
Show resolved
Hide resolved
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
changed the title
renaudhartert-db
requested changes
May 13, 2025
databricks-sdk-java/src/main/java/com/databricks/sdk/core/DefaultCredentialsProvider.java
Outdated
Show resolved
Hide resolved
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/EnvVarIDTokenSource.java
Outdated
Show resolved
Hide resolved
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/EnvVarIDTokenSource.java
Show resolved
Hide resolved
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/FileIDTokenSource.java
Outdated
Show resolved
Hide resolved
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/FileIDTokenSource.java
Show resolved
Hide resolved
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
reviewed
May 14, 2025
Contributor
parthban-db
left a comment
parthban-db
left a comment
There was a problem hiding this comment.
Overall looks good. Few small comments.
Comment on lines
31
to
37
| // Test case name, file path (null means create temp file), file content, expected token, | ||
| // expected exception | ||
| Arguments.of("Valid token file", null, TEST_TOKEN, TEST_TOKEN, null), | ||
| Arguments.of("Token with whitespace", null, " " + TEST_TOKEN + " ", TEST_TOKEN, null), | ||
| Arguments.of("Empty file", null, "", null, DatabricksException.class), | ||
| Arguments.of("File with only whitespace", null, " ", null, DatabricksException.class), | ||
| Arguments.of("Null file path", null, null, null, IllegalArgumentException.class), |
Contributor
There was a problem hiding this comment.
I am not sure I understand this correctly. What are you trying to test in the Null file path because it will create the file anyway.
Contributor
Author
There was a problem hiding this comment.
The file is only created if the file content is not null, so in cases where the content is null, no file will be created. But I agree that the previous logic was a bit convoluted, so I’ve refactored the tests to make them more straightforward and intuitive.
databricks-sdk-java/src/test/java/com/databricks/sdk/core/oauth/FileIDTokenSourceTest.java
Outdated
Show resolved
Hide resolved
databricks-sdk-java/src/test/java/com/databricks/sdk/core/oauth/FileIDTokenSourceTest.java
Show resolved
Hide resolved
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/EnvVarIDTokenSource.java
Outdated
Show resolved
Hide resolved
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/FileIDTokenSource.java
Outdated
Show resolved
Hide resolved
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
approved these changes
May 15, 2025
Contributor
renaudhartert-db
left a comment
renaudhartert-db
left a comment
There was a problem hiding this comment.
LGTM! Thanks Emmy
parthban-db
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add Environment Variable and File-based ID Token Sources
Key Changes
EnvVarIDTokenSourceto read ID tokens from environment variablesFileIDTokenSourceto read ID tokens from filesIDTokenSourceinterface for OIDC authenticationHow is this tested?
NO_CHANGELOG=true