Make Makefile use venv #1192
Open
Make Makefile use venv #1192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tejas-Kochar
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Tejas-Kochar
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Tejas-Kochar
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Tejas-Kochar
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Tejas-Kochar
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Tejas-Kochar
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
The current Makefile activates a virtual environment but does not actually use it, as commands on different lines run in different processes.
This manifested as a failure in this job run because of the wrong version of a dependancy being used. It passes after including the fix in it: see here.
This PR ensures the activated venv is used by explicitly using the path to it.
How is this tested?
Added a test which checks whether
.venvis in the path of the Python installation being used.See this job run to see the test failing.
See this job run from after the fix (test made to fail with an assert False).
You can verify this yourself by running
make devfollowed bymake lint. It will fail if you don't have pycodestyle installed in your local python installation. If you switch to this branch and then runmake devfollowed bymake lint, it will succeed.NO_CHANGELOG=true