Enable Legacy Profiles/Config in Unified Mode#1240
Open
hectorcast-db wants to merge 18 commits intomainfrom
Open
Enable Legacy Profiles/Config in Unified Mode#1240hectorcast-db wants to merge 18 commits intomainfrom
hectorcast-db wants to merge 18 commits intomainfrom
Conversation
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
force-pushed
the
hectorcast-db/remove-is-x
branch
from
d1df107 to
30a73f6
Compare
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
force-pushed
the
hectorcast-db/remove-is-x
branch
from
a1ea877 to
55b09a8
Compare
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
commented
Feb 3, 2026
|
|
||
| def __set__(self, cfg: "Config", value: any): | ||
| cfg._inner[self.name] = self.transform(value) | ||
| if value is None: |
Contributor
Author
There was a problem hiding this comment.
This is a bug fix. Before, this:
cfg.account_id = None
would actually set
cfg.account_id = "None"
hectorcast-db
commented
Feb 3, 2026
| continue | ||
| return environment | ||
| return get_environment_for_hostname(self.host) | ||
| if not self.experimental_is_unified_host: |
Contributor
Author
There was a problem hiding this comment.
We now resolve this once during new Config, not lazily. This ensures that we don't read the host after Config is created.
hectorcast-db
commented
Feb 3, 2026
| if self.azure_workspace_resource_id: | ||
| return True | ||
| return self.environment.cloud == Cloud.AZURE | ||
| return self.environment is not None and self.environment.cloud == Cloud.AZURE |
Contributor
Author
There was a problem hiding this comment.
Unified Hosts will return false on all 3 clouds.
hectorcast-db
commented
Feb 3, 2026
| return None | ||
| if self.cluster_id and self.warehouse_id: | ||
| raise ValueError("cannot have both cluster_id and warehouse_id") | ||
| headers = self.authenticate() |
Contributor
Author
There was a problem hiding this comment.
Extracted to a separate func
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR adds support for Legacy Profiles/Config in Unified Mode.
This allows us to test the detection/fallback logic and the changes happening to the legacy workspace logic.
How is this tested?
Run integration tests twice: one with unified flag and one without it.