Add custom_attributes struct to metadata #2055
Open
+41
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulmadanahalli
requested review from
chtyim,
fernst,
kolina and
zaptot
and removed request for
a team
rahulmadanahalli
changed the title
kolina
requested changes
Dec 17, 2025
Contributor
kolina
left a comment
kolina
left a comment
There was a problem hiding this comment.
Integration tests are failing
| message Metadata { | ||
| string overview = 1; | ||
| google.protobuf.Struct custom_attributes = 2; | ||
| } |
Contributor
There was a problem hiding this comment.
Are attributes is relevant name here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.