feat: CORS probe #359
Open
feat: CORS probe #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinocroustibat
force-pushed
the
cors-probe
branch
2 times, most recently
from
e195013 to
204fa6f
Compare
Pierlou
approved these changes
Nov 12, 2025
Contributor
Pierlou
left a comment
Pierlou
left a comment
There was a problem hiding this comment.
Clean and concise 👏 just a couple of NIT notes
maudetes
reviewed
Nov 17, 2025
Contributor
maudetes
left a comment
maudetes
left a comment
There was a problem hiding this comment.
I'm always unsure about the proper way to get the needed CORS values.
| ) | ||
|
|
||
| if cors_probe := await probe_cors(session, url): | ||
| cors_payload = build_cors_payload(cors_probe) |
Contributor
There was a problem hiding this comment.
Should we store this cors_payload in the checks table directly? I think everytime we want to debug something, it's useful to get the state at check time (the same way we store headers)
Co-authored-by: Pierlou Ramade <48205215+Pierlou@users.noreply.github.com>
bolinocroustibat
force-pushed
the
cors-probe
branch
from
8428872 to
055ff56
Compare
bolinocroustibat
force-pushed
the
cors-probe
branch
from
c58cc50 to
ccd3c88
Compare
commit 866d1d7 Author: Adrien Carpentier <adrien.carpentier@numerique.gouv.fr> Date: Fri Nov 21 10:36:44 2025 +0100 fix: resolve async/await compatibility issues with Typer CLI (#361) This PR fixes CLI commands that were broken after migrating from minicli to Typer, which doesn't handle async functions directly. All async CLI commands are now wrapped with synchronous functions that use `_make_async_wrapper()` to detect the execution context and run async code appropriately. The wrapper automatically detects if an event loop is already running (for tests) or creates one using `asyncio.run()` (for CLI execution), ensuring compatibility with both direct CLI usage and async test environments. The unused `cleanup()` function has been removed, and redundant exception handling (`except Exception as e: raise e`) has been cleaned up. All CLI commands now work correctly without RuntimeWarnings about unawaited coroutines. ... ...but it's VERY ugly and verbose.
commit a43d2d4 Author: Adrien Carpentier <adrien.carpentier@numerique.gouv.fr> Date: Fri Nov 21 15:44:14 2025 +0100 feat: optimize cleanup of stuck status resources (#363) Replaces the iterative cleanup approach with a single SQL UPDATE query that processes all stuck resources at once, improving performance in `load_catalog`. **Performance improvement:** - Before: 1 SELECT query + N UPDATE queries (one per stuck resource) - After: 1 single UPDATE query with subquery - Reduces database round-trips and allows PostgreSQL to optimize the operation atomically commit 80eb0fd Author: Adrien Carpentier <adrien.carpentier@numerique.gouv.fr> Date: Fri Nov 21 15:25:54 2025 +0100 feat: add total resources and deleted resources in crawler status health check (#362) - Add total resources and deleted resources in crawler status health check (to be later used in Munin dashboards) - Reorganize crawler health check output to be more explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #360 (sub-issue of described issue here datagouv/data.gouv.fr#1810)
Send a preflight OPTIONS request to collect the CORS headers of the distant ressource, and send them to udata to be stored in the extras.