fix: fetch(attrs, as_dict=True) excludes unrequested primary key#1403
Closed
dimitri-yatsenko wants to merge 1 commit intomasterfrom
Closed
fix: fetch(attrs, as_dict=True) excludes unrequested primary key#1403dimitri-yatsenko wants to merge 1 commit intomasterfrom
dimitri-yatsenko wants to merge 1 commit intomasterfrom
Conversation
…y key
In 0.14.x, fetch('col1', 'col2', as_dict=True) returned dicts containing
only the requested attributes. In 2.x, proj() always includes primary key
attributes, so the returned dicts contained extra keys the caller didn't ask
for. Filter the dicts to only include requested attributes, restoring
backward compatibility.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
Won't fix — the 2.x behavior of always including primary key in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores 0.14.x behavior where
fetch('col1', 'col2', as_dict=True)returned dicts containing only the requested attributes.In 2.x,
proj()always includes primary key attributes, so the returned dicts contained extra keys the caller didn't ask for. This breaks downstream code that concats the result with an existing DataFrame that already has the primary key column — the concat creates duplicate columns and subsequent groupby fails.The fix filters each dict after
to_dicts()to include only the requested attributes. This is safe regardless of row order because we are removing keys from individual dicts, not rearranging rows.Reproducing the issue
Test plan
fetch('attr', as_dict=True)returns dicts without primary keyfetch('KEY', 'attr', as_dict=True)still includes primary key (explicitly requested)