Skip to content

Conversation

@BenjaminCharmes
Copy link
Contributor

Closes #1485

  • Remove legend_label from circle glyphs to prevent point/line desynchronization when toggling legend visibility
  • Add sequential numbering to shortened legend labels that would otherwise be identical after truncation (e.g., "CIF_00...xrdml [01]", "CIF_00...xrdml [02]")

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 78.87324% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.04%. Comparing base (020cc77) to head (29e518a).

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/utils.py 75.80% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1489      +/-   ##
==========================================
- Coverage   79.12%   79.04%   -0.08%     
==========================================
  Files          71       71              
  Lines        5413     5550     +137     
==========================================
+ Hits         4283     4387     +104     
- Misses       1130     1163      +33     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/apps/xrd/blocks.py 90.27% <ø> (ø)
pydatalab/src/pydatalab/bokeh_plots.py 80.36% <100.00%> (+0.81%) ⬆️
pydatalab/src/pydatalab/utils.py 76.39% <75.80%> (-10.09%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Dec 11, 2025

datalab    Run #4371

Run Properties:  status check passed Passed #4371  •  git commit 59a895c49b ℹ️: Merge 29e518acea0e1a80fa90487ae32708696b668b57 into 020cc770e22581fddcfdfdba2feb...
Project datalab
Branch Review bc/xrd-fix
Run status status check passed Passed #4371
Run duration 09m 09s
Commit git commit 59a895c49b ℹ️: Merge 29e518acea0e1a80fa90487ae32708696b668b57 into 020cc770e22581fddcfdfdba2feb...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 458
View all changes introduced in this branch ↗︎

@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review December 11, 2025 14:22
@ml-evs ml-evs added this to the v0.7.x milestone Dec 16, 2025
@ml-evs ml-evs force-pushed the bc/xrd-fix branch 2 times, most recently from 44186ad to a86b030 Compare December 18, 2025 01:49
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend behaviour works fine (could merge this separately) but think the label generation still needs some work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XRD block plots missing line in legend and other behaviours

3 participants