Skip to content

Conversation

@xmedr
Copy link
Contributor

@xmedr xmedr commented Apr 17, 2025

Overview

This adds some of the highway contract route addresses, county roads, directional placenames, and addresses without streetnameposttypes found in prs #258, #259, #251, and #222 to the testing/training data (shoutouts to @bbharathrao, @rptetzloff, and @ecatkins). I'm opening a new pr instead of adding those mostly because of the new testing suite that comes with prs here nowadays, and the new way in which we're adding data to the one file instead of having multiple files.

Labelling for HCR boxes should look like:

  • input: HC 235 Box 1A
  • output: ('HC', 'USPSBoxGroupType'),
    ('235', 'USPSBoxGroupID'),
    ('Box', 'USPSBoxType'),
    ('1A', 'USPSBoxID')

Labelling for county roads should look like:

  • input: County Rd MM, Granada, CO
  • output: ('County', 'StreetNamePreType'),
    ('Rd', 'StreetNamePreType'),
    ('MM,', 'StreetName'),
    ('Granada,', 'PlaceName'),
    ('CO', 'StateName')

Labelling for directional placenames without streetnameposttypes look like:

  • input: 1600 NE 4th Fort Lauderdale, FL
  • output: ('1600', 'AddressNumber'),
    ('NE', 'StreetNamePreDirectional'),
    ('4th', 'StreetName'),
    ('Fort', 'PlaceName'),
    ('Lauderdale,', 'PlaceName'),
    ('FL', 'StateName')

Testing

  • Confirm that the test suite passes
  • (Optional) Pull down this branch and follow the new instructions in the readme to locally spot check some addresses like:
    • HC 267 Box 22
    • Highway contract Rte 1 Box 77Z

@xmedr xmedr marked this pull request as ready for review April 17, 2025 21:22
@xmedr xmedr requested a review from derekeder April 17, 2025 21:22
@xmedr xmedr changed the title Add data for highway contract route addresses Add data for highway contract route and county road addresses May 1, 2025
@xmedr xmedr changed the title Add data for highway contract route and county road addresses Add data for a handful of different cases May 2, 2025
@xmedr
Copy link
Contributor Author

xmedr commented May 2, 2025

@derekeder I've got testing/training data from all the older prs that were still open into this one as well (all noted in the description), so this'll bring a whole swath of updates when it's brought in.

Copy link
Member

@derekeder derekeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! instructions work locally for me, test addresses work as expected.

@xmedr xmedr merged commit 753a4fb into main May 7, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PlaceName in StateName

3 participants