STREAM-770: Added support for tuple datatype #217
+78
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyanshu-ctds
changed the title
connector/src/main/java/com/datastax/oss/pulsar/source/converters/AbstractNativeConverter.java
Outdated
Show resolved
Hide resolved
connector/src/test/java/com/datastax/oss/pulsar/source/PulsarCassandraSourceTests.java
Outdated
Show resolved
Hide resolved
msmygit
reviewed
Dec 19, 2025
connector/src/main/java/com/datastax/oss/pulsar/source/converters/AbstractNativeConverter.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/datastax/oss/pulsar/source/converters/AbstractNativeConverter.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/datastax/oss/pulsar/source/converters/AbstractNativeConverter.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/datastax/oss/pulsar/source/converters/AbstractNativeConverter.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/datastax/oss/pulsar/source/converters/AbstractNativeConverter.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/datastax/oss/pulsar/source/converters/NativeAvroConverter.java
Outdated
Show resolved
Hide resolved
| // any field to non-null value will cause the udt column itself to be null in the C* table | ||
| UdtValue zudtOptionalValues = zudt.newValue(dataSpecMap.get("text").cqlValue); | ||
|
|
||
| TupleType tupleType = DataTypes.tupleOf(DataTypes.INT, DataTypes.TEXT); |
Member
There was a problem hiding this comment.
Will you please able to add a complex test case of a CQL column of type map<text, frozen<tuple<text, text, bigint, double, text>>> in addition to the simple tuple type here?
| int idx = Integer.parseInt(fieldName.substring("index_".length())); | ||
| if (idx == 0) { | ||
| Assert.assertEquals(dataSpecMap.get("int").avroValue, value); | ||
| } else if (idx == 1) { |
Member
There was a problem hiding this comment.
I don't understand this fully, so please bear with my limited knowledge here. Are we stopping just at the 2nd field? What if the tuple field has more than 2 fileds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datastax.jira.com/browse/STREAM-770