Fix broken links to pages with the same name as title#12
Merged
daxcore merged 3 commits intodaxcore:mainfrom Feb 10, 2026
Merged
Fix broken links to pages with the same name as title#12daxcore merged 3 commits intodaxcore:mainfrom
daxcore merged 3 commits intodaxcore:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @daxcore, I adopted your plugin for one of my personal projects and find it really great. However, I found that if the project's name is included in one of the links it would not create the graph properly. Consider the following scenario:
Example page/docs/ExampleExample page/indexIn your implementation, for the link
Example, the regex would capture both of the above expressions and would later choose theindexpage rather than the correctExamplepage, since it's shorter.This MR fixes the issue by adjusting the regex to match against nodes, that are at the end of the path and also adds tests that show the issue. I also made some slight refactors to parts of the plugin.