Skip to content

Bump click minimum version to 8.3.1 #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stratakis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump click minimum version to 8.3.1 #1556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ Contributors:
* Jay Knight (jay-knight)
* fbdb
* Charbel Jacquin (charbeljc)
* Charalampos Stratakis

Creator:
--------
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ urls = { Homepage = "https://pgcli.com" }
requires-python = ">=3.9"
dependencies = [
"pgspecial>=2.0.0",
"click >= 4.1,<8.1.8",
"click >= 8.3.1",
Copy link
Contributor

@meeuw meeuw Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe try this?

Suggested change
"click >= 8.3.1",
"click >= 4.1,<8.3.2",

Copy link
Author

@stratakis stratakis Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will "allow" some configs with broken click versions to be used (8.1.8 to 8.3.0). I could exclude all the problematic ranges, which would be ugly to put in pyproject toml but doable. I could also explore fixing the compatibility issue in pgcli.

Would something like click >= 4.1, != 8.1.8, != 8.2.*, != 8.3.0, < 9 work? Noting that the next click version would be 9, not 8.3.2

"Pygments>=2.0", # Pygments has to be Capitalcased.
# We still need to use pt-2 unless pt-3 released on Fedora32
# see: https://github.com/dbcli/pgcli/pull/1197
Expand Down
Loading