This repository was archived by the owner on Apr 15, 2021. It is now read-only.
Added multiwindow command #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented suggestion from issue [dcchambers#15](dcchambers#15). I attempted to make the main window come to the front but I think the PORT messages are destroyed by the time the function is called and `chrome.windows` is inaccessible. I also didn't want to modify messenger.js too much before the code gets refactored/rewritten.
I had `drawAttention` in the window update because I was trying to get the port listener to work but I forgot to change it back to `focused` when committing. Doesn't affect functionality right now but later down the road if this does get added `focused` is the update param needed.
Owner
|
Nice, looking forward to testing this. |
This is purely for this branch and should not be included in the main fork of vb4c.
This reverts commit 8797285. I don't want this included in the pull request but I can't "ignore" it as far as I can tell. I am reverting so it doesn't get included at all.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented suggestion from issue #15. I attempted to make the main window come to the front but I think the
PORTmessage listeners are destroyed by the time the function is called andchrome.windowsis inaccessible. I also didn't want to modify messenger.js too much before the code gets refactored/rewritten.