Skip to content

Conversation

@stasadev
Copy link
Member

@stasadev stasadev commented Apr 16, 2025

The Issue

How This PR Solves The Issue

Reverts the last change, it's fixed upstream:

Manual Testing Instructions

docker pull adminer:standalone
ddev add-on get https://github.com/ddev/ddev-adminer/tarball/20250416_stasadev_plugin_revert
ddev restart

Automated Testing Overview

Release/Deployment Notes

@rfay
Copy link
Member

rfay commented Apr 16, 2025

I could wish that there was a new docker image tag, so people who got this already wouldn't stay broken.

@stasadev
Copy link
Member Author

I tested different pull_policy values https://github.com/compose-spec/compose-spec/blob/main/05-services.md#pull_policy

All these weekly, daily fail without internet, so people need to manually run the pull.


BTW, we may be able to solve it with:

If we pull everything, ignore all errors, and only then run docker-compose up.

@stasadev stasadev merged commit fc6c8e5 into main Apr 16, 2025
2 checks passed
@stasadev stasadev deleted the 20250416_stasadev_plugin_revert branch April 16, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants