Deleted unnecessary checks if certain fields were None#13
Closed
cjappl wants to merge 1 commit intodeanmcgregor:masterfrom
Closed
Deleted unnecessary checks if certain fields were None#13cjappl wants to merge 1 commit intodeanmcgregor:masterfrom
cjappl wants to merge 1 commit intodeanmcgregor:masterfrom
Conversation
Author
|
I think #9 is the much more correct way of doing this, and should be preferred if you have the chance to merge that. |
jazzmoe
approved these changes
May 22, 2021
Author
|
As a temporary measure, you’re welcome to work off the main branch of my fork. I have recently fixed a few more issues where optional fields would throw.
Based on the state of this main fork, I think the maintainer is a little MIA
…On Sat, May 22, 2021 at 7:05 AM, Moritz Hemmerlein ***@***.***> wrote:
I encountered the same issues as in [#8](#8) and would appreaciate a merge if ***@***.***(https://github.com/cjappl) 's fix solves the issue
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#13 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ADMDXY5F3I2WWVI25NAVFPLTO6TX7ANCNFSM436N5LQA).
|
|
I'd like to contribute - I actively try to build a useful application linking my different bank accounts to ynab. Can I somehow download your version to my python package folder. How would that work? |
Author
|
@jazzmoe you can find my fork here https://github.com/cjappl/ynab-python You can install directly with
Or, you can clone the repo, navigate to the top level directory and install locally If you have any issues, head over to my fork and report it, we can work on it together! |
|
Lovely, thank you for this easy fix 👍 |
Author
|
Closing, seems like this repo is dead. RIP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
#7
#8