-
Notifications
You must be signed in to change notification settings - Fork 146
fix incorrect usd fee error when sending usdc #3458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix incorrect usd fee error when sending usdc #3458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for working on this @JustinBeBoy .
There's still an issue regarding the transaction history that I'm trying to resolve. |
|
I'm not sure the transactions not showing up is a bug. Will put more on the issue. |
|
As @martonp said on the issue, we might not be able to get the incoming transactions. If you just fix the amounts with this pr it's fine. Maybe a note in the UI about not showing incoming transactions if you are ok with making that. Don't worry about it too much as may be impossible currently. |
I've researched this issue, and it might not be a bug, but rather that rate sources could be disabled or failing (network error, API rate limit), hiding the USD element. It seems that stablecoins like USDC might not be supported by all APIs. |
Ok no big deal. If it's not a bug just leave it. |
|
@JoeGruffins please help me review and test it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where the USD fee estimate was calculated incorrectly when sending USDC or other token assets. The issue occurred because tokens pay transaction fees in their parent asset (e.g., USDC on Polygon pays fees in MATIC), but the USD conversion was incorrectly using the token's fiat rate instead of the parent asset's rate.
Key Changes:
- Fixed USD fee calculation to use the parent asset's fiat rate and unit info when sending tokens
- Added polling-based transaction history scanner (per PR description, but not visible in provided diffs)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b9894e1 to
af4a3bc
Compare






Close #3457
This PR:
Screen Shot:
before:
after: