Skip to content

Conversation

@JustinBeBoy
Copy link
Contributor

@JustinBeBoy JustinBeBoy commented Dec 28, 2025

Close #3457

This PR:

  • fix incorrect usd fee error when sending usdc.
  • Add a polling-based scanner with block-range chunking to retrieve transaction history.

Screen Shot:

  • USD fee:

p1 p2 p3

  • Transaction history

before:

p1 p2

after:

pr1

Copy link
Member

@peterzen peterzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for working on this @JustinBeBoy .

@JustinBeBoy
Copy link
Contributor Author

LGTM. Thank you for working on this @JustinBeBoy .

There's still an issue regarding the transaction history that I'm trying to resolve.

@JoeGruffins
Copy link
Member

Looks good. I notice there is a usd price here for the base coin but not for the token. Under Amount. Can you try to fix it too?

image image

@JustinBeBoy
Copy link
Contributor Author

Looks good. I notice there is a usd price here for the base coin but not for the token. Under Amount. Can you try to fix it too?

image image

Let me fix it.

@JoeGruffins
Copy link
Member

I'm not sure the transactions not showing up is a bug. Will put more on the issue.

@JoeGruffins
Copy link
Member

JoeGruffins commented Dec 29, 2025

As @martonp said on the issue, we might not be able to get the incoming transactions. If you just fix the amounts with this pr it's fine. Maybe a note in the UI about not showing incoming transactions if you are ok with making that. Don't worry about it too much as may be impossible currently.

@JustinBeBoy
Copy link
Contributor Author

Looks good. I notice there is a usd price here for the base coin but not for the token. Under Amount. Can you try to fix it too?

image image

I've researched this issue, and it might not be a bug, but rather that rate sources could be disabled or failing (network error, API rate limit), hiding the USD element. It seems that stablecoins like USDC might not be supported by all APIs.

@JoeGruffins
Copy link
Member

I've researched this issue, and it might not be a bug, but rather that rate sources could be disabled or failing (network error, API rate limit), hiding the USD element. It seems that stablecoins like USDC might not be supported by all APIs.

Ok no big deal. If it's not a bug just leave it.

@JustinBeBoy JustinBeBoy marked this pull request as ready for review January 6, 2026 04:51
Copilot AI review requested due to automatic review settings January 6, 2026 04:51
@JustinBeBoy
Copy link
Contributor Author

@JoeGruffins please help me review and test it.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the USD fee estimate was calculated incorrectly when sending USDC or other token assets. The issue occurred because tokens pay transaction fees in their parent asset (e.g., USDC on Polygon pays fees in MATIC), but the USD conversion was incorrectly using the token's fiat rate instead of the parent asset's rate.

Key Changes:

  • Fixed USD fee calculation to use the parent asset's fiat rate and unit info when sending tokens
  • Added polling-based transaction history scanner (per PR description, but not visible in provided diffs)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JustinBeBoy JustinBeBoy force-pushed the udsc_polygon_irregularities branch from b9894e1 to af4a3bc Compare January 6, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

USDC/Polygon wallet irregularities

3 participants