Skip to content

Conversation

@deepanshs
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #94 (fe7dc84) into master (d7135c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #94   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         7107      7107           
=========================================
  Hits          7107      7107           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7135c7...fe7dc84. Read the comment docs.

mgiammar
mgiammar previously approved these changes Nov 22, 2021
Comment on lines +285 to +293
"repository_url": "https://github.com/DeepanshS/mrsimulator",
"use_repository_button": True,
"use_issues_button": True,
"use_download_button": True,
"launch_buttons": {
"notebook_interface": "jupyterlab",
"binderhub_url": "https://mybinder.org",
"colab_url": "https://colab.research.google.com",
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current example pages built by Sphinx Gallery don't have these buttons added. However, the html of the page has a spot where these buttons should go. Adding the launch functionality is a matter of getting Jupyter Book to recognize the pages built by Sphinx Gallery as needing these buttons.

I think merging this PR is good for now and the issue of adding the buttons can come later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants