-
Notifications
You must be signed in to change notification settings - Fork 33
feat: DH-21093: Make usePersistentState available to all panels #2595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2595 +/- ##
==========================================
+ Coverage 45.54% 45.96% +0.42%
==========================================
Files 771 771
Lines 43636 43649 +13
Branches 11041 11229 +188
==========================================
+ Hits 19872 20065 +193
+ Misses 23748 23539 -209
- Partials 16 45 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mofojed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the e2e tests then this looks good
|
Tested w/ ACL editor (which was the reason the check needed to be added in |
Removed
extendStatefrom GL because we did not use it (and don't in DHE). It also tripped me up because it mutates the existing object, so calling it does not trigger a state change for Dashboard which means it doesn't actually save any extended state on its own.