Skip to content

Conversation

@mattrunyon
Copy link
Collaborator

@mattrunyon mattrunyon commented Dec 18, 2025

Removed extendState from GL because we did not use it (and don't in DHE). It also tripped me up because it mutates the existing object, so calling it does not trigger a state change for Dashboard which means it doesn't actually save any extended state on its own.

@mattrunyon mattrunyon self-assigned this Dec 18, 2025
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 38.23529% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.96%. Comparing base (656c090) to head (4cdfc20).

Files with missing lines Patch % Lines
.../golden-layout/src/utils/ReactComponentHandler.tsx 0.00% 11 Missing ⚠️
...kages/golden-layout/src/container/ItemContainer.ts 0.00% 5 Missing ⚠️
packages/dashboard/src/DashboardLayout.tsx 50.00% 2 Missing and 1 partial ⚠️
packages/dashboard/src/DashboardPanelWrapper.tsx 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2595      +/-   ##
==========================================
+ Coverage   45.54%   45.96%   +0.42%     
==========================================
  Files         771      771              
  Lines       43636    43649      +13     
  Branches    11041    11229     +188     
==========================================
+ Hits        19872    20065     +193     
+ Misses      23748    23539     -209     
- Partials       16       45      +29     
Flag Coverage Δ
unit 45.96% <38.23%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattrunyon mattrunyon requested a review from mofojed January 5, 2026 16:10
@mattrunyon mattrunyon marked this pull request as ready for review January 5, 2026 16:10
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the e2e tests then this looks good

@mattrunyon mattrunyon requested a review from mofojed January 5, 2026 21:53
@mattrunyon
Copy link
Collaborator Author

Tested w/ ACL editor (which was the reason the check needed to be added in _gotReactComponent). It is a functional component w/ forwardRef which triggers the logic. It's actually not an issue any more (only was w/ my initial iteration which patched the state into the same object as the class component persisted state). But the check and types are more accurate so I'm leaving them. The e2e was failing because the check was looking for componentWillUpdate to exist. There are other example utils that check component.isReactComponent, but the types didn't like that narrowing at all and instanceof Component seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants