-
Notifications
You must be signed in to change notification settings - Fork 2.6k
test: add delete_all_documents, delete_by_filter and update_by_filter generic tests to haystack.testing.document_store
#10477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
delete_all_documents tests to DeleteDocumentsTest mixindelete_all_documents tests to DeleteDocumentsTest mixin
Pull Request Test Coverage Report for Build 21717270304Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
delete_all_documents tests to DeleteDocumentsTest mixindelete_all_documents, delete_by_filter update_by_filter tests to DeleteDocumentsTest mixin
delete_all_documents, delete_by_filter update_by_filter tests to DeleteDocumentsTest mixindelete_all_documents, delete_by_filter update_by_filter tests to haystack.testing.document_store
delete_all_documents, delete_by_filter update_by_filter tests to haystack.testing.document_storedelete_all_documents, delete_by_filter and update_by_filter generic tests to haystack.testing.document_store
anakin87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good.
I left a few minor comments.
Co-authored-by: Stefano Fiorucci <stefanofiorucci@gmail.com>
anakin87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the adjustments!
Related Issues
Proposed Changes:
delete_all_documents():normal behaviour, empty store, and optional recreate_index (True/False).delete_by_filter():matching docs, no matches, and AND/OR filters.UpdateByFilterTestforupdate_by_filter(): basic update, no matches, multiple fields, and AND/OR filters.DocumentStoreBaseTestsincludesUpdateByFilterTestHow did you test it?
haystack-core-integrationsand made sure all passedpytest.skip()when a store doesn’t implement delete_all_documents, delete_by_filter, or update_by_filter, or when recreate_index isn’t supported.NOTE:
This needs to be merged before deepset-ai/haystack-core-integrations#2812 is merged into
haystack-core-integrationsChecklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.