Skip to content

Conversation

@davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Jan 30, 2026

Related Issues

Proposed Changes:

  • New tests for:
    • delete_all_documents(): normal behaviour, empty store, and optional recreate_index (True/False).
    • delete_by_filter(): matching docs, no matches, and AND/OR filters.
    • UpdateByFilterTest for update_by_filter(): basic update, no matches, multiple fields, and AND/OR filters.
  • Tests that don’t need self are now @staticmethod;
  • DocumentStoreBaseTests includes UpdateByFilterTest

How did you test it?

  • Locally run the full (existing plus these new ones) for all of our document stores in haystack-core-integrations and made sure all passed
  • New tests use pytest.skip() when a store doesn’t implement delete_all_documents, delete_by_filter, or update_by_filter, or when recreate_index isn’t supported.

NOTE:

This needs to be merged before deepset-ai/haystack-core-integrations#2812 is merged into haystack-core-integrations

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel
Copy link

vercel bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview Feb 5, 2026 3:22pm

Request Review

@github-actions github-actions bot added the type:documentation Improvements on the docs label Jan 30, 2026
@davidsbatista davidsbatista changed the title feat: add delete_all_documents tests to DeleteDocumentsTest mixin feat: add delete_all_documents tests to DeleteDocumentsTest mixin Jan 30, 2026
@coveralls
Copy link
Collaborator

coveralls commented Feb 3, 2026

Pull Request Test Coverage Report for Build 21717270304

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 92.562%

Files with Coverage Reduction New Missed Lines %
core/pipeline/async_pipeline.py 2 66.67%
Totals Coverage Status
Change from base Build 21715008796: -0.01%
Covered Lines: 14884
Relevant Lines: 16080

💛 - Coveralls

@davidsbatista davidsbatista changed the title feat: add delete_all_documents tests to DeleteDocumentsTest mixin test: add delete_all_documents, delete_by_filter update_by_filter tests to DeleteDocumentsTest mixin Feb 4, 2026
@davidsbatista davidsbatista marked this pull request as ready for review February 4, 2026 15:14
@davidsbatista davidsbatista requested a review from a team as a code owner February 4, 2026 15:14
@davidsbatista davidsbatista requested review from sjrl and removed request for a team February 4, 2026 15:14
@davidsbatista davidsbatista changed the title test: add delete_all_documents, delete_by_filter update_by_filter tests to DeleteDocumentsTest mixin test: add delete_all_documents, delete_by_filter update_by_filter tests to haystack.testing.document_store Feb 4, 2026
@davidsbatista davidsbatista changed the title test: add delete_all_documents, delete_by_filter update_by_filter tests to haystack.testing.document_store test: add delete_all_documents, delete_by_filter and update_by_filter generic tests to haystack.testing.document_store Feb 4, 2026
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good.

I left a few minor comments.

davidsbatista and others added 3 commits February 5, 2026 15:20
@davidsbatista davidsbatista removed the type:documentation Improvements on the docs label Feb 5, 2026
@github-actions github-actions bot added the type:documentation Improvements on the docs label Feb 5, 2026
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the adjustments!

@davidsbatista davidsbatista merged commit 1257102 into main Feb 5, 2026
21 checks passed
@davidsbatista davidsbatista deleted the feat/add-delete-all-documents-tests branch February 5, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants