Conversation
TanviKumar
reviewed
Feb 7, 2019
venkat24
reviewed
Feb 8, 2019
hrishikeshshekhar
force-pushed
the
GoldMine
branch
from
803b6b2 to
e44f847
Compare
venkat24
requested changes
Feb 10, 2019
| factory->IncrementConstructionCompletion( | ||
| factory->GetTotalConstructionCompletion()); | ||
|
|
||
| // Expecting gold manager calls when factory transitions from UNBUILD state |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Expecting gold manager calls when factory transitions from UNBUILD state | |
| // Expecting gold manager calls when factory transitions from UNBUILT state |
hrishikeshshekhar
force-pushed
the
GoldMine
branch
from
bd6d62b to
dfe23c0
Compare
- Add an interface for GoldManager. - Add forward declarations Actor and GoldManager to fix circular dependecy. - Add GoldMines for easy accessing GoldMines
- Add helper functions in GoldManager and a hash map to map GoldMine to number of requests
- Add logic to create request for mining gold from a mine
- Change GoldManager constructors in logger_test.cpp, soldier_test.cpp, factory_test.cpp, villager_test.cpp, state_test.cpp
- Remove segmentation faults in villager tests caused due to inavailability of gold mines
- Changing gold mines in gold manager to unique pointers and changing the mine requests to type pointers for keys
- Removing GoldManager dependency in all tests and adding GoldManagerMock
- Add GoldManager expectations for villager_test.cpp - Add GoldManager expectations for soldier_test.cpp - Add GoldManager expectations for logger_test.cpp - Add GoldManager expectations for factory_test.cpp - Add GoldManager expectations for state_test.cpp
- Add test for checking if MineRequests are added - Add test to check if gold is split in the right ratio when multiple villagers are mining the same GoldMine
- Remove getter and setter functions in GoldMine - Add gold manager mock in soldier tests
- Fix merge conflicts in state_test.cpp, logger_test.cpp
hrishikeshshekhar
force-pushed
the
GoldMine
branch
from
dfe23c0 to
ac71276
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the issue of splitting gold in case a mine has a limited amount of gold to deliver