build(deps): bump org.apache.httpcomponents.core5:httpcore5 from 5.3.6 to 5.4#8192
build(deps): bump org.apache.httpcomponents.core5:httpcore5 from 5.3.6 to 5.4#8192dependabot[bot] wants to merge 4 commits intomainfrom
Conversation
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
Bumps [org.apache.httpcomponents.core5:httpcore5](https://github.com/apache/httpcomponents-core) from 5.3.6 to 5.4. - [Changelog](https://github.com/apache/httpcomponents-core/blob/master/RELEASE_NOTES.txt) - [Commits](apache/httpcomponents-core@rel/v5.3.6...rel/v5.4) --- updated-dependencies: - dependency-name: org.apache.httpcomponents.core5:httpcore5 dependency-version: '5.4' dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
5343d13 to
a11d980
Compare
|
As of now, 'build and test docker' job is failing Related discussion linked to this error: https://lists.apache.org/thread/5pmyy8xclqwht49gccy3xvnd2pmv2pz4 |
|
That's a bad decision on their part IMHO, seems there are more robust solutions available. Putting that aside, I wonder if it happens on regular Temurin image builds? Possibly, given Temurin is referenced in that issue. That would also be an official library base image which would be better practice than using custom Azul registry images. |
I do not believe there is any issue with the Azul JDK from the Azul registry. The current approach—explicitly declaring the modules we use in our Docker image—is a good practice. It reduces the build size and minimizes the attack surface by removing unnecessary modules. Importing the The pipeline is now green. I plan to conduct additional tests to assess the potential impact of this change, as I am concerned it might break some user execution setups. In addition to the change itself, I would welcome feedback on what type of release this change should be classified as (patch, minor, or major), based on the information provided. |
…ore5-httpcore5-5.4
|
Oh yes, it's doing custom jlink, I forgot. So that mostly rules out concerns with the base image. Separately, I think that custom jlink is probably not a good idea either - given the level of automated testing across this project and the analyzers/data sources with their own custom libraries/APIs. This project has a large amount of dependency sprawl making it difficult to reason about the correct modules needed - and probably much higher value to reduce the dependency sprawl than remove more JDk modules. And its more to maintain.... This being discovered seems like luck more than anything. |
|
A newer version of org.apache.httpcomponents.core5:httpcore5 exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps org.apache.httpcomponents.core5:httpcore5 from 5.3.6 to 5.4.
Changelog
Sourced from org.apache.httpcomponents.core5:httpcore5's changelog.
... (truncated)
Commits
0ca2ddeHttpCore 5.4 release5a3e465Updated release notes for HttpCore 5.4 release69a7663Fix validation of 0/8 IPv4 addressesa70a62cRoute-segmented pool: fix timeout race; add direct hand-off; enforce TTL on l...b3fc3f3Ensure connection is closed immediately upon socket timeout729e2a8H2 Priority example clean-up4e640ffAccept leading zeros in IPv4-mapped IPv6 (#568)030f51fUpgraded HttpCore version to 5.4-alpha2-SNAPSHOT9be094eHttpCore 5.4-alpha1 releasedfb42f4Javadoc fixYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)