Conversation
| "chargé d'affaires", | ||
| "chargé d’affaires", | ||
| "king's", | ||
| "king’s", |
There was a problem hiding this comment.
Suggestion from my side would be to normalize the apostrophes and dashes prior to matching against these lists. There are too many variations to capture them all.
There was a problem hiding this comment.
Absolutely agreed; I did not take the time to take a look if this happens already somewhere in the code… Obviously there's a bunch of misused characters that might function as apostrophes, even if we only take into account latin script, e.g. '’‘' and the backtick that ` creates the <code/>. Search the unicode.org charts for all other apostrophes for other writing systems
There was a problem hiding this comment.
I would benefit from this MR as I will have to deal with German names soon. Would it be reasonable to move the debate about apostrophes to a dedicated issue so that the rest of the contribution could be released?
There was a problem hiding this comment.
Fine by me. The PR is quite old. So I guess it needs to have conflicts resolved etc.
3 participants
Inspired by the question on "frau" (in #99), I dropped in a couple more titles from German language (specifically from nobility titles of 19th century Austrian government members).