feat: add sorting utility and integrate into Board and Column components #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new sorting utility, sortIntoArray, and integrates it into both the Board and Column components to improve dynamic ordering of notes and columns.
- Introduces sortIntoArray in utils.ts with accompanying tests in utils.test.ts
- Updates Column and Board components to use sortIntoArray for maintaining order
- Updates package.json with additional testing dependency (vitest)
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/utils.ts | Added sortIntoArray function to insert items in order |
| src/lib/utils.test.ts | Introduced comprehensive tests for sortIntoArray |
| src/components/Column.tsx | Replaced memoized sorting with a reactive store for filtered notes |
| src/components/Board.tsx | Replaced memoized column sorting with a reactive store implementation |
| package.json | Added vitest dependency and updated unocss dependency version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.