Skip to content

Conversation

@rohanKanojia
Copy link
Member

What does this PR do?

Add ginkgo to the prerequisites list as it's required for running tests locally. Also add a new "Running Tests" section that documents:

  • How to install ginkgo
  • How to ensure ginkgo is in PATH
  • How to run tests with make test
  • Note about ginkgo vs go test fallback behavior

This addresses the missing documentation about test requirements for local development.

What issues does this PR fix or reference?

This PR addresses a gap in the documentation that was discovered during an internal slack discussion. The Prerequisites section mentioned various tools needed for development, but omitted ginkgo, which is required for the full test suite to run properly.

Is it tested? How?

N/A

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Add ginkgo to the prerequisites list as it's required for running tests
locally. Also add a new \"Running Tests\" section that documents:
- How to install ginkgo
- How to ensure ginkgo is in PATH
- How to run tests with make test
- Note about ginkgo vs go test fallback behavior

This addresses the missing documentation about test requirements for
local development.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2026

@rohanKanojia: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-devworkspace-operator-e2e 412a780 link true /test v14-devworkspace-operator-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, rohanKanojia
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants