fix: corebluetooth peripheral name#447
Conversation
|
Thank you for working on this! I should be able to do some testing this week and share feedback. |
|
I finally had a chance to test this in our setup. It works exactly as expected. Really nice solution. Thanks @szymonlesisz! |
qdot
left a comment
There was a problem hiding this comment.
Ok, this does seem like the correct thing to do, and probably should've been done from the start but we're still dealing with issues we inherited from forking 7+ years ago heh.
Main issue is going to be adapting it to the rest of the platforms so we're consistent, but I'll handle that.
I'm happy to help with testing when you have a PR ready. |
Followup to #447, we'll want to make sure we emit on change to either.
Followup to #447, we'll want to make sure we emit on change to either.
|
@tternes It's actually sitting on dev now because I wasn't watching what I was doing heh. Feel free to give it a shot. |
as well described here peripheral
local_nameandadvertisement_nameare two different things and it is justified to keep them separated as situation that local_name is not equal advertisement_name could happen in all platforms and can be implemented later as followup.currently it is quite unfortunate that the API changes the peripheral local_name (GAP) by joining those two values
changes:
Peripheral.advertisement_name- default Nonefix: #434