Skip to content

Conversation

@nimbinatus
Copy link
Member

Removing all possible blockers to Netlify code checks from archived sites.

Signed-off-by: Laura Santamaria <nimbinatus@users.noreply.github.com>
@nimbinatus nimbinatus self-assigned this Dec 17, 2025
@nimbinatus nimbinatus requested a review from a team as a code owner December 17, 2025 17:13
@netlify
Copy link

netlify bot commented Dec 17, 2025

Deploy Preview for devopsdays-web ready!

Name Link
🔨 Latest commit 1923e03
🔍 Latest deploy log https://app.netlify.com/projects/devopsdays-web/deploys/6942e7fafcda8b0008227fd5
😎 Deploy Preview https://deploy-preview-15624--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Laura Santamaria <nimbinatus@users.noreply.github.com>
Copy link
Collaborator

@phrawzty phrawzty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to be honest with you here: I pointed Claude Code at this and it thinks the PR is clean and ready to merge. :)

> There is a PR in `upstream`: https://github.com/devopsdays/devopsdays-web/pull/15624
It touches a _lot_ of files, and the diffs are large enough that they aren't being shown in the github web interface.
The problem is that Netlify, which does the builds of this site, is detecting "secrets" and refuses to build. The "secrets" it is detecting are old google maps keys from ancient parts
of the site. This is functionality which doesn't even exist anymore, so this PR is meant to remove not only the (stale) "secrets", but the whole google maps code blocks entirely.
Please verify the PR against the desired outcome; i.e. it's doing what we expect and not anything else.

[…]

⏺ Perfect! I've completed my review of PR #15624. Here's my analysis:

  PR Summary

  - Files changed: 107 files (all in static/events/YYYY-CITY/location/index.html or local/index.html)
  - Scope: Archived events from 2015-2018
  - Changes: 2,715 deletions, 29 additions
  - Author: Laura Santamaria (@nimbinatus)

  What's Being Removed ✅

  The PR is doing exactly what you expected:

  1. Google Maps API Key: Removing a single stale API key: AIzaSyC1bvNK9qFJGEhoWNbQuojmJJ1Tg0DoOew
  2. Google Maps Code Blocks: Removing entire commented-out sections containing:
    - <div id="map_canvas"> elements
    - JavaScript initMap() functions that used the Google Maps API
    - Script tags loading https://maps-api-ssl.google.com/maps/api/js
    - Hardcoded lat/long coordinates and map initialization code

  What's NOT Being Changed ✅

  - No other functionality affected: The rest of the HTML files remain intact
  - No sponsor information removed: All sponsor sections are preserved
  - No navigation changes: Event navigation and page structure unchanged
  - No other secrets or keys: Only the single Google Maps API key is being removed

  Additions (The 29 lines)

  The small number of additions are just:
  - Whitespace adjustments (like adding <br> tags) where the Google Maps blocks were removed
  - HTML continuations after the deleted sections (this is normal diff behavior)

  Verdict ✅

  The PR is clean and does exactly what it's supposed to do. It's systematically removing obsolete Google Maps code and the associated API key that Netlify is flagging as a "secret" from 100 archived event location pages. No unintended changes or side effects detected.

Good enough for me, tbqh.

@nimbinatus nimbinatus merged commit f4a0a05 into devopsdays:main Dec 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants