-
Notifications
You must be signed in to change notification settings - Fork 0
Add Tabs component and LibraryPage with Overview, Components, and Hooks #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
src/pages/LiberyPage/index.tsx
Outdated
| @@ -0,0 +1,21 @@ | |||
| import { Typography as T } from '../../core/typography' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name of the file is LiberyPage, should be LibraryPage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
src/pages/LiberyPage/index.tsx
Outdated
| export default function LibraryPage() { | ||
| return ( | ||
| <> | ||
| <T.Heading3 style={{ margin: 20 }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use token for margin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
src/pages/LiberyPage/index.tsx
Outdated
| <T.Heading3 style={{ margin: 20 }}> | ||
| Welcome to React Vite Template | ||
| </T.Heading3> | ||
| <T.BodyBase style={{ margin: 20 }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this file needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted
Pull Request
Description
This PR introduces a new Tabs component and restructures the app to include a LibraryPage that serves as the main entry point for exploring the component library.
Key changes:
How to test
Install and start the project:
npm installnpm run devOpen localhost
Check accessibility:
Verify design:
Type of Change
feature: New featurechore: Maintenance, dependency updates, or refactoringtest: Adding or improving testsbug: Bug fixdocs: Documentation updatesShortcut story
Related Issues
Testing Performed
Screenshots/Recordings
Checklist
Additional Notes