Add content to Overview tab with SectionCard + List component #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasminePRA
reviewed
Aug 25, 2025
src/main.tsx
Outdated
| <Routes> | ||
| //TODO: Add more routes that takes you to different template pages | ||
| <Route path="/" element={<App />} /> | ||
| <Route index element={<LibraryPage />} /> |
Collaborator
There was a problem hiding this comment.
App needs to be rendered here. In App, we can have different elements being rendered, but main.tsx shouldn't know of our components
JasminePRA
reviewed
Aug 25, 2025
src/pages/LiberyPage/index.tsx
Outdated
| import { Typography as T } from '../../core/typography' | ||
| import Tabs from '../../components/common/organisms/Tabs' | ||
| import { Main } from '../../components/common/styled' | ||
| import { LIBRARY_TABS } from './tabs.config' |
Contributor
Author
There was a problem hiding this comment.
Changed to LiberyTabs
JasminePRA
reviewed
Aug 25, 2025
| @@ -0,0 +1,32 @@ | |||
| export const overviewSections = [ | |||
Contributor
Author
There was a problem hiding this comment.
I used .config here to make it clear this file is only exporting static configuration data (no logic). Happy to rename it. I can rename it to overview.ts to keep it simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR adds info under the Overview section.
To achieve this, I also introduced some new building blocks to make the structure more scalable:
The Overview tab now contains:
How to test
Install and start the project:
npm installnpm run devOpen the Overview tab and Verify that:
Check styling:
Type of Change
feature: New featurechore: Maintenance, dependency updates, or refactoringtest: Adding or improving testsbug: Bug fixdocs: Documentation updatesShortcut story
https://trello.com/c/Hq1p9oUC/14-feature-layout-tab-preview-overview
Related Issues
Testing Performed
Screenshots/Recordings
Checklist
Additional Notes