Conversation
pkg/git/RepositoryManager.go
Outdated
Comment on lines
379
to
397
pkg/git/GoGitSDKManager.go
Outdated
Comment on lines
137
to
156
Contributor
There was a problem hiding this comment.
why is this here?
pkg/git/GitCliManager.go
Outdated
Comment on lines
195
to
213
pkg/git/GitBaseManager.go
Outdated
Comment on lines
78
to
87
Contributor
There was a problem hiding this comment.
need to have a look
pkg/git/GitBaseManager.go
Outdated
pkg/git/GitBaseManager.go
Outdated
pkg/git/GitCliManager.go
Outdated
Comment on lines
11
to
14
pkg/git/GoGitSDKManager.go
Outdated
Comment on lines
12
to
14
| // } | ||
| type GoGitSDKManagerImpl struct { | ||
| *GitManagerBaseImpl | ||
| GitManagerBase |
Contributor
There was a problem hiding this comment.
interface here but impl in cliManager. why?
Contributor
There was a problem hiding this comment.
can we make interfaces in both places?
Contributor
Author
There was a problem hiding this comment.
Yes sure....Used interface in cliManager as well
pkg/git/Watcher.go
Outdated
kazhuravlev
reviewed
Jul 10, 2024
| import ( | ||
| "context" | ||
| "github.com/devtron-labs/git-sensor/internal/sql" | ||
| "github.com/devtron-labs/git-sensor/internals/sql" |
There was a problem hiding this comment.
internal directory - is a special name that do not allow others to import any package under this directory. So after renaming it to internals - anyone can import this packages. I am almost sure that this is not a main goal of this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring done to make structs and interfaces extended