feat: support large wasms #288
Open
+194
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwshang
reviewed
Jan 21, 2026
Contributor
There was a problem hiding this comment.
I'd like to avoid committing large binaries to the repo if possible.
A few questions:
- How was this 3MB Wasm module generated?
- Could we replace it with a script or dummy project that generates the binary at build/test time?
If we don't need to verify canister installation by making actual calls (i.e., the module doesn't need functional endpoints), we could generate a dummy Wasm module padded to the required size. Something like a minimal module with a large data segment would be valid Wasm but contain no real logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #273