Added the MMB option to the Connect command #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds a middle mouse button (MMB) option to the Connect command in Wings3D, enabling users to dynamically increase the number of parallel edges by dragging the mouse. The implementation required modifications to the dragging system to properly update the model state and selection after command completion.
Key Changes:
- Adds
connect_multiplecommand that creates multiple parallel edges with interactive count adjustment - Introduces a new
countunit type to the drag system for integer-based adjustments - Updates the normalize functions to track and update selection state during drag operations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| src/wings_edge_cmd.erl | Adds connect_multiple command with interactive edge count adjustment via dragging; updates menu tooltips for the Connect command |
| src/wings_drag.erl | Introduces count unit type with integer limits; updates normalize functions to track selection changes during drag operations; adds support for count display in help messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
I have let co-pilot review this, fix stuff that seems valid and write when your are done, or nothing needs fixing. |
…ally increase the amount of cut;
updated on screen. That happens when an operation add more elements dynamically, like in this code which we add multiple connections that bacome selected for better feedback.
are integer values which was not handled before.
Micheus
force-pushed
the
mv/new-connect-MMB-option
branch
from
4c91996 to
0f65bbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent two days traying to add an MMB option to the Connect command that could
allow us to connect edges multiple times by dragging the mouse on screen as we
use to do other adjustments.
The way the dragging code works currently doesn't updates correctly the model after
we finish the command. So, I changed it a little and it's working gracefully now.
It was required to check for selection changes as well as force dlist to be invalidated.
I hope you can approve this change or suggest a better way to achieve the result. This
kind of dynamic update could be used in other commands we can add further.
NOTE: Added the MMB option to the Connect command, allowing us to dynamically
increase the amount of cut;