Workaround to fix text colour not changing in status bar #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Here is a sample image: |
Owner
|
I have let co-pilot review this, fix stuff that seems valid and write when your are done, or nothing needs fixing. |
There was a problem hiding this comment.
Pull request overview
This PR implements a workaround for a known wxWidgets issue where the text color in the status bar doesn't properly change according to theme settings on native controls. The solution involves custom painting the status bar using a paint event callback, which provides full control over rendering including text colors and a custom grip icon.
Key changes:
- Implemented custom painting via
custom_draw/2callback to manually render status bar text and grip icon - Added
draw_grip/3helper function to draw a Windows-style resize grip - Fixed indentation inconsistency on line 54
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
It was noticed that the text color in the status bar doesn't change according to the theme settings. Looking for info I found that it's an know issue in wxWidgets which setting the color of native controls is not always possible. Considering we use the wxFLAT style, drawing the status bar ourselves is the easiest and most effective way to work around this issue. I included a grip icon similar to the Windows version, since no system resource is available for use (as with other system icons). NOTE: Fixed a theme issue that was preventing the status bar text from using its setting in the theme color. Thanks to Nova711 (on Discord).
Micheus
force-pushed
the
mv/v2.4-fix-temes-colours-issue
branch
from
014c396 to
ab83f4d
Compare
Micheus
force-pushed
the
mv/v2.4-fix-temes-colours-issue
branch
from
ab83f4d to
79e873a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was noticed that the text color in the status bar doesn't change according to the theme settings. Looking for info I found that it's an know issue in wxWidgets which setting the color of native controls is not always possible.
Considering we use the wxFLAT style, drawing the status bar ourselves is the easiest and most effective way to work around this issue. I included a grip icon similar to the Windows version, since no system resource is available for use (as with other system icons).
NOTE:
Fixed a theme issue that was preventing the status bar text from using its setting in the theme color. Thanks to Nova711 (on Discord).