-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Postgres tuning revision #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Modified README to clarify the way config settings are applied to a running postgresql server
| Custom configuration for Postgresql can be done by adding to the files in the `./config/postgresql/conf.d/` directory. If your configuration doesn't belong in either of the existing files, you can create a new file. However, it's advised not to make changes to the [postgresql.conf](config/postgresql/postgresql.conf) file. | ||
|
|
||
| ## Deployment For Production | ||
| Some postgresql configuration parameters can be applied by reloading the configuration. Others will only take effect when the database is restarted. The detailed description of each configuration option (on postgresql v16) is avalable [here](https://www.postgresql.org/docs/16/runtime-config.html). The documentation for each setting generally indicates whether the setting requires a restart in order to take effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have multiple double spaces in this paragraph
| ``` | ||
|
|
||
| ### Deployment Prerequisites | ||
| If you need to restart the database server, it is safest to stop the application container first, restart the database, then start the application again. This will mean some minutes of downtime for your users so it is best to co-ordinate such operations with users or execute during quiet times of the day. A typical sequence might look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have multiple double spaces in this paragraph
changed postgres restart instructions as ber suggestion Co-authored-by: tonsV2 <tonsV2@users.noreply.github.com>
Philip-Larsen-Donnelly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The additions look sensible, but unfortunately this PR branch is based on quite an old version of the README.md, so it can't be merged as is.
Made a few tuning changes