Draft
Conversation
fostah
approved these changes
Aug 27, 2025
mressler
approved these changes
Aug 27, 2025
mressler
left a comment
mressler
left a comment
There was a problem hiding this comment.
And with a fun build and publishing extension. Nice, Brian!
| } | ||
|
|
||
| @Test | ||
| fun `WHEN calculateBitrateAndBandwidth called multiple times THEN return total bitrate and bandwidth stats`() = runTest { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rebases our changes onto the version 2.6.4 from pedroSG94/RootEncoder.
There were significant changes in the upstream. I removed our changes to fix Tap to Focus because they were already fixed in the upstream. I had to rework our modifications around the streaming stats.
Here is the original change made by Charles
Here is my corresponding change
To update, I found where the new system calls queue.trySend, and added the call to
BitrateManager.queuedBytessimilar to the original.I then combined the existing
calculateBitrateand the oldcalculateBandwidthto makecalculateBitrateAndBandwidth. The plan is to use the results of calculateBitrate and some other public APIs to replace the bandwidth calculation. This allows us to use this library and safely move away from needing to modify RootEncoder.