Skip to content

Conversation

@Sparks29032
Copy link
Collaborator

Used to break for multiple subdirectories within the many-morphs directories.

@codecov
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.87%. Comparing base (641b5e7) to head (29a8fe8).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   96.85%   96.87%   +0.02%     
==========================================
  Files          18       18              
  Lines         795      801       +6     
==========================================
+ Hits          770      776       +6     
  Misses         25       25              
Files with missing lines Coverage Δ
tests/test_tools.py 98.90% <100.00%> (+0.07%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably needs tests, or is it being tested but the tests didn't need to be changed. If so, ere they failing before? If not they need to be extended....

@Sparks29032
Copy link
Collaborator Author

Yes, tests needed. I think adding 2 directories with blank files to testsequence is sufficient if the tests still pass as there is no specific output given when directories are parsed out.

@Sparks29032
Copy link
Collaborator Author

Tests pass. Good to merge?

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see inline

@@ -0,0 +1 @@
This directory should be ignored by PDFmorph.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not do it with tmpdir dynamically in the test? We normally wouldn't do it this way by creating junk in the source repo.

@Sparks29032
Copy link
Collaborator Author

Closing for fresh bugfix branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants