-
Notifications
You must be signed in to change notification settings - Fork 23
fix: change camelcase to snakecase in all private functions #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sbillinge
merged 59 commits into
diffpy:main
from
cadenmyers13:rm-camelcase-privatefuncs
Dec 10, 2025
Merged
fix: change camelcase to snakecase in all private functions #138
sbillinge
merged 59 commits into
diffpy:main
from
cadenmyers13:rm-camelcase-privatefuncs
Dec 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage 66.60% 66.60%
=======================================
Files 25 25
Lines 3171 3171
=======================================
Hits 2112 2112
Misses 1059 1059
🚀 New features to boost your workflow:
|
Contributor
Author
|
@sbillinge ready for review |
Contributor
|
@cadenmyers13 nicely done there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these are private functions, no deprecation warning is needed. This was my process:
_myPrivateFunction())_myPrivateFunction()to_my_private_function())_my_private_function)I did this for all files under
srcincluding thepdfandsas(will have to update indiffpy.cmipdftoo but should be easy). After a local installation, all tests passed (see below). To be extra sure, I ran all cmi script examples too with the local installation and they all worked.