Add copy() method for DiffractionObject
#204
Conversation
tests/test_diffraction_objects.py
Outdated
| xtype="tth", | ||
| ) | ||
| copy_of_DO = do.copy() | ||
| assert do == copy_of_DO |
There was a problem hiding this comment.
Utilzing the object's __eq__ nice implementation
There was a problem hiding this comment.
To complete this test also assert id(actual) != Id(initial)
There was a problem hiding this comment.
Then the copy is not pointing to the same object
|
@sbillinge ready for review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 96.49% 96.54% +0.05%
==========================================
Files 8 8
Lines 342 347 +5
==========================================
+ Hits 330 335 +5
Misses 12 12
|
tests/test_diffraction_objects.py
Outdated
| xtype="tth", | ||
| ) | ||
| copy_of_DO = do.copy() | ||
| assert do == copy_of_DO |
There was a problem hiding this comment.
To complete this test also assert id(actual) != Id(initial)
tests/test_diffraction_objects.py
Outdated
| xtype="tth", | ||
| ) | ||
| copy_of_DO = do.copy() | ||
| assert do == copy_of_DO |
There was a problem hiding this comment.
Then the copy is not pointing to the same object
|
@sbillinge Right! Thank you. Additional test added. |
|
@sbillinge ready for review - just enhanced the variable name from |
|
@bobleesj not sure why codecov is complaining here...diffpy has a global org secret token. Maybe it is being flaky. I will just try and rerun it? after than an empty commit? |
Codecov looks okay to me in fact 0.05% has gone up! @sbillinge |
it failed to upload so failed. I reran it and it uploaded and passed..... CC is officially flaky.... |
2 participants
Closes #201 - add
copy()forDiffracitonObject