Fix all remaining divide by zero pytest warnings #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobleesj
commented
Dec 21, 2024
| ] | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( |
Contributor
Author
There was a problem hiding this comment.
Just moving them under @pytest.mark.parametrize - no numbers have been modified.
bobleesj
commented
Dec 21, 2024
|
|
||
|
|
||
| @pytest.mark.parametrize("init_args, expected_error_msg", test_init_invalid_params) | ||
| @pytest.mark.parametrize( |
Contributor
Author
There was a problem hiding this comment.
I will further refine these comments with higher level commets, etc. in the following PRs (issues have been created for these)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 391 404 +13
=========================================
+ Hits 391 404 +13
|
bobleesj
commented
Dec 21, 2024
Contributor
Author
bobleesj
left a comment
bobleesj
left a comment
There was a problem hiding this comment.
@sbillinge ready for review - no numbers have been modified.
| def test_d_to_tth(wavelength, d, expected_tth, wavelength_warning_msg): | ||
| if wavelength is None: | ||
| def test_d_to_tth(wavelength, d, expected_tth, divide_by_zero_warning_expected, wavelength_warning_msg): | ||
| if wavelength is None and not divide_by_zero_warning_expected: |
Contributor
Author
There was a problem hiding this comment.
I am thinking we could make a reusable test util function under conftest.py - that takes in d_to_tth, tth_to_d, etc and capture these warning messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #223
This PR focused on catching warnings. In the following PRs, I will focus on checking test comments and refactoring into reusable components with
conftest.py