Config updater workflow #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need to get the updated user_filesystem fixture so merging main next
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
===========================================
+ Coverage 98.68% 100.00% +1.31%
===========================================
Files 8 8
Lines 379 405 +26
===========================================
+ Hits 374 405 +31
+ Misses 5 0 -5
|
Contributor
Author
|
@bobleesj @yucongalicechen @alisnwu this is ready for review |
Contributor
|
Just another comment - looks like this function does not have docstring yet |
sbillinge
commented
Dec 25, 2024
Contributor
Author
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
Thanks for the comments @yucongalicechen. I fixed them. Writing the docstring also made me realize we may want to return the status of if a config file is found. Then a user could use the function with the skip but if it returns False make their own workflow, which is nice and flexible. Great reviews everyone!
Contributor
|
seems like a conflict created now hm.. |
Contributor
Author
|
Ok, I will fix and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #244
This is the new separate workflow for updating the config file if it is found to be missing in home.