Open
Conversation
Member
davidlehn
commented
Jun 30, 2023
davidlehn
commented
- Use JSON style and eslint rules for easy copy & paste.
- Debatable change to the js/context.js file. It does make it easier to do things like fiddle in the playground and copy & paste the context back into the file. But it's a bit odd looking, maybe? Thoughts?
- Use JSON style and eslint rules for easy copy & paste.
BigBlueHat
approved these changes
Dec 7, 2023
BigBlueHat
left a comment
BigBlueHat
left a comment
There was a problem hiding this comment.
Love it! Just some questions in the review.
| type: '@type' | ||
| // Use JSON style for context | ||
| /* eslint quotes: ["error", "double"] */ | ||
| /* eslint quote-props: ["error", "always"] */ |
There was a problem hiding this comment.
I wish we had a custom "inline JSON" rule that would set these.
We should probably also shut off max-len too (per your great work elsewhere).
| * Copyright (c) 2023 Digital Bazaar, Inc. All rights reserved. | ||
| */ | ||
| /* eslint-disable-next-line quotes */ | ||
| 'use strict'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.